Repository navigation
mark an invalid CPU delta as stale - #49
Merged
Merged
Conversation
An accepted CPU sample cleared the stale flag before the usage delta was checked. When that delta is invalid and a previous percent exists, keep the percent, skip history, and report the page stale until a later valid sample, including a real 0%, replaces it. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An accepted CPU sample always cleared
system_sample_stalebefore checkingcpu_delta_valid. An invalid delta kept the previous percent and did not push history, but the page stayed Ready, so that old percent looked current.CpuPageState::apply_system_samplenow marks the sample stale when the delta is invalid and a previouscpu_usageexists. The percent and history stay unchanged. With no previous usage,cpu_usageremainsNoneand a placeholder 0 is not pushed. A later valid sample, including a real 0%, clears stale, stores that percent, and pushes it.derive_statusthen returnsCpuPageStatus::Stale, which already usesTextKey::CpuRefreshFailedStale.Test
invalid_cpu_delta_marks_retained_usage_stale_until_measured_zerocovers the no-previous invalid delta, a retained percent marked stale, and the following measured 0%.Linux could not compile Windows resources (
llvm-rcis not installed). The change is limited tosrc/pages/cpu/mod.rs.