Repository navigation
advance disk baselines on a zero interval. - #50
Merged
Merged
Conversation
A zero query interval now stores the current counters and stays NoRate, so bytes that moved while the clock was frozen are not counted on the next real interval. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commit_disk_readingstreatedDiskDelta::ZeroIntervalas a no-op. Bytes that moved whilequery_timestayed put were left out of the baseline and then counted on the next real interval, which can look like a spike.On a zero interval, that drive's baseline is now the current counters and those bytes are not added to the summed rate. If every drive is a zero interval, the update is still
DiskActivityUpdate::NoRatewith the baselines advanced. A zero interval is not turned into a 0 B/s success rate. Reset, overflow, and a real rate are unchanged.Test
After a zero-interval sample whose byte counters increased, the following real interval reports only the bytes since that sample. Two related cases cover every drive being a zero interval, and a zero-interval drive sitting beside a drive that has a real rate.
cargo teston this host stops in the Windows resource build becausellvm-rcis not installed. The disk counter functions and their unit tests were compiled and run from the same source on the host: 12 passed, including the existing reset, overflow, and rate cases.cargo fmt --all -- --checkandgit diff --checkpassed.