Repository navigation
do not queue a duplicate session action - #51
Merged
Merged
Conversation
Drop a later Users-page command when the same kind and session identities are already pending. A different session, kind, or logon time stays queued, and a coalesced refresh still does not erase those actions. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9cead3d74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A second logoff or disconnect can become the first pending request without passing through merge. Remember commands still outstanding and do not submit the same kind and session identities again until that work finishes. Co-authored-by: jameslincn <jameslincn@outlook.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two logoff or disconnect clicks for the same session were both running while the worker was busy. The second call failed because the session was already gone, and the existing failure dialog made a successful logoff look failed.
merge_user_requestsno longer appends a command whose kind and session identities are already queued. A different session, a different kind, or a different logon time stays queued. A coalesced refresh still does not erase queued actions, and an action still replaces a pending refresh.Test
identical_session_actions_collapse_and_different_sessions_remain, next topending_session_action_survives_a_coalesced_refresh, checks that two identical actions collapse to one and that a different session and a different logon time both remain.repeated_session_action_is_not_submitted_while_the_worker_is_busychecks the in-flight guard.Linux could not compile the Windows resources (
llvm-rcis absent), socargo testwas not run here. The edit is limited tosrc/pages/users.rs.