Repository navigation
cover processor groups at the pointer width - #52
Merged
Merged
Conversation
Exercise a full group of usize::BITS processors and an active count of usize::BITS + 1 on every pointer width. Masks shift only when the bit index is below usize::BITS, and a wider group returns OutOfRangeAffinityMask. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/system/cpu_topology.rs.usize::BITSprocessors, one bit each, builds successfully andmatches_sample_lenequals that count. Masks are shifted only when the bit index is belowusize::BITS.usize::BITS + 1returnsCpuTopologyError::OutOfRangeAffinityMaskand does not panic. These tests run on both 32-bit and 64-bit targets.Groups that already fit in
usizekeep the existing success path.Test plan
cargo test --locked --bin taskmgr pointer_width_group_builds_one_bit_per_processorcargo test --locked --bin taskmgr active_count_above_pointer_width_is_out_of_rangeThis environment cannot compile Windows resources because
llvm-rcis not installed, so the package tests were not executed here. The new tests callbuild_topologydirectly and do not need a live processor query.