Repository navigation
move process affinity off the UI thread - #53
Merged
Merged
Conversation
The affinity dialog stays on the UI thread. After confirmation, the process identity and selected group masks are queued on the existing process-action worker. That worker re-opens the target with open_process_for_identity before SetProcessAffinityMask or SetProcessDefaultCpuSets. An unknown identity, a mask that does not fit the native KAFFINITY, or a group that cannot be expressed fails without writing a truncated mask. A later failure is not reported as success. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Set Affinity dialog stays on the UI thread. After the user confirms, the verified
ProcIdentityand the selected per-group masks are queued on the existing process-actionSingleFlightWorker(the same worker that already runs End Process, End Process Tree, and Set Priority). No extra window message is posted, and the UI thread does not join the worker.Before
SetProcessAffinityMaskorSetProcessDefaultCpuSets, the worker re-opens the target withopen_process_for_identity(pid andcreation_time_100ns). An unknown or mismatched identity returns without writing a mask. A group or mask that nativeKAFFINITYcannot express fails explicitly and is not truncated to the low bits. A failure after a CPU-set or thread update is reported with the existing affinity error text and is not treated as success.Test plan
cargo check --target x86_64-pc-windows-msvc --all-targets --lockedcargo check --target i686-pc-windows-msvc --all-targets --lockedcargo check --target aarch64-pc-windows-msvc --all-targets --lockedcargo clippy --target x86_64-pc-windows-msvc --all-targets --locked -- -D warnings