Repository navigation
reject a CPU sample with no elapsed time - #54
Merged
Merged
Conversation
A missing or zero interval set valid before the elapsed check, and a failed detail counter returned before that check ran. Leave valid false, report InvalidElapsedTime, and do not publish processor percents from that interval. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculate_cpu_deltasetvalidbefore checking elapsed time, and a failed detail counter returned immediately. A zero or missing interval could therefore be published as a real CPU percent.A missing or zero
elapsed_msnow leavesvalidfalse and reportsCpuDiagnosticError::InvalidElapsedTimebefore processor percents are written. A nonzero interval with a healthy total still setsvalidtrue, including a real 0% idle sample. Detail-counter failures are still reported when the interval is nonzero.Test
Host unit run of the sampler delta tests (the Windows resource link is not available here):
valid