Repository navigation
reject an empty processor performance query - #55
Merged
Merged
Conversation
A successful NtQuerySystemInformation result with a zero returned length is not a sample. Return an error and drop the default-zero counters instead of treating them as idle time. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A successful processor-performance query with a zero returned length used to return
Ok(())and leave the output vector filled with default zero times. Those zeros are not a sample.returned == 0is an error, and the default-zero rows are cleared.Ok.The status decision lives in a pure function and is unit-tested. Only
src/system/cpu_sampler.rschanged.Testing
The configured Windows MSVC build stops on this Linux agent because
llvm-rcis not installed, so the full package tests were not run. The pure tests insrc/system/cpu_sampler.rswere compiled and run without the Windows resource step: 11 passed, including zero-length success, an exact multiple, and a non-multiple length. The live processor-count test still needs Windows.