Repository navigation
do not treat an unknown process machine as native - #56
Merged
Merged
Conversation
IsWow64Process2 reports IMAGE_FILE_MACHINE_UNKNOWN for every non-WOW64 process. Without a reported machine, return an error on every host instead of labeling that unknown process native. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classify_machinestreated a process as native whenIsWow64Process2reportedIMAGE_FILE_MACHINE_UNKNOWNand no process machine was reported. ARM64 already returnedERROR_NOT_SUPPORTEDfor that case. Other hosts took the finalNone => native_machinearm and labeled the unknown processExecutionMode::Native.An unknown process machine is now an error on every host. A machine that was actually reported, or that came from a known WOW64 machine, still uses the existing success path, including a real native match.
Test
unknown_process_machine_is_an_error_and_reported_native_stays_nativechecks that an unknown process machine isErr(ERROR_NOT_SUPPORTED)on ARM64, AMD64, and I386, and that a reported native machine is stillExecutionMode::Native.Linux cannot compile the Windows resource script (
llvm-rcis not installed), so this crate's tests were not executed here.