Repository navigation
fix(site): seed the index from a local file - #181
Merged
Merged
Conversation
A failed Pages fetch started the rebuild from an empty index, so a multi-channel deploy silently dropped the other channels' refs. Allow build-site to read the published index from a local file, and warn loudly when the Pages seed is unavailable. Fixes #180.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180.
Problem
build-siteseeded its cumulative index by fetching<pages-url>/index/static. Every failure(timeout, non-200, Pages propagation delay) was logged at debug and the build continued from an empty
index. On a repository with more than one channel, the rebuild then contained only the current
channel's refs, so the other channel's refs disappeared silently after a successful deploy.
Change
--index-file <path>(envAETHERPAK_INDEX_FILE) tobuild-site, mapping toSiteOptions.IndexFile. When set, the index is read from the local file and the Pages index fetchis skipped; a missing or malformed seed fails the build.
Resultsarray, so an error envelope served with HTTP 200cannot masquerade as an empty index.
pointing at
--index-file.Testing
the current record's digest wins.
Results, andnullResultsresponses.TestLoadSeedIndexReportsUnavailableSeedpins that a failed Pages seed is reported rather thanswallowed.
go test ./...,go vet ./..., andmake lintpass.