Skip to content

Fix segment NDV statistics restoration. - #138

Closed
woblerr wants to merge 0 commit into
apache:mainfrom
woblerr:fix_integration
Closed

woblerr wants to merge 0 commit into
apache:mainfrom
woblerr:fix_integration

Conversation

@woblerr

@woblerr woblerr commented Nov 7, 2026

Copy link
Copy Markdown
Contributor
  • Generate float8 arrays instead of int8 arrays for Cloudberry segment NDV statistics (kind 8) to preserve their original type and support fractional values.
  • Cover integer and fractional NDV values in the unit test.
  • Add an integration regression test for restoring fractional NDV statistics in the fifth slot.

Related to #65.

@talmacschen-arch talmacschen-arch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MisterRaindrop

Copy link
Copy Markdown

Thanks @woblerr! This change is already on main: #139 included this commit and was squash-merged, so AnyValues() now uses float8 for STATISTIC_KIND_NDV_BY_SEGMENTS and the new integration test is in as well. Comparing this branch with main shows nothing left to merge, so I think this PR can be closed.

@tuhaihe

tuhaihe commented Nov 10, 2026

Copy link
Copy Markdown
Member

Thanks @woblerr! This change is already on main: #139 included this commit and was squash-merged, so AnyValues() now uses float8 for STATISTIC_KIND_NDV_BY_SEGMENTS and the new integration test is in as well. Comparing this branch with main shows nothing left to merge, so I think this PR can be closed.

Yep. When I tried to rebase this pull request, it was closed automatically. I guess it was due to the reasons above. 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants