Skip to content

Fix external table metadata and integration test portability. - #139

Merged
tuhaihe merged 4 commits into
apache:mainfrom
woblerr:fix_integration_remaining
Nov 10, 2026
Merged

tuhaihe merged 4 commits into
apache:mainfrom
woblerr:fix_integration_remaining

Conversation

@woblerr

@woblerr woblerr commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Depends on #138.

  • Return an empty reject limit type instead of char(-1) for external tables without a reject limit.
  • Compare attribute statistics with pg_statistic instead of hardcoded slots and NDV values.
  • Use C instead of de_DE in collation tests and remove German locale setup from CI.

Closes #65.

@talmacschen-arch talmacschen-arch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cloudberry stores segment NDV statistics (kind 8) as float8 arrays, but gpbackup generated int8 arrays. Fractional NDV values caused statistics restoration with --with-stats to fail, while integer values were restored with the wrong element type.

Generate float8 arrays for kind 8 and add regression coverage for fractional NDV values.
Cloudberry can return a non-NULL char(-1) marker on unsigned-char platforms when no reject limit is configured.
@tuhaihe
tuhaihe force-pushed the fix_integration_remaining branch from 0968ebf to 3bee8a8 Compare November 10, 2026 07:28
@tuhaihe
tuhaihe merged commit 2d8fb44 into apache:main Nov 10, 2026
20 checks passed
@woblerr
woblerr deleted the fix_integration_remaining branch November 10, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make integration errors returned

4 participants