Repository navigation
ghost-node installer: GHOST_MINE_TO mines straight to the tester's own wallet ad - #121
Merged
Merged
Conversation
install.sh, install.ps1 and install.cmd read GHOST_MINE_TO. It must be 0x followed by exactly 40 hex characters; anything else is refused before anything is downloaded or installed. With it, the config's Etherbase is that address and no mining key or password file is made. A re-run, or an install.sh --update, with GHOST_MINE_TO set rewrites only the Etherbase line and restarts the node; without it the config is kept as before. Unset, the installers make a new key exactly as before. Every install now ends by printing 'mining to: <address>', and each script's header gives the one-line examples for sh and PowerShell. The Windows scripts write or rewrite the config before ghost-setup runs, since ghost-setup keeps an existing config and so makes no key. ghost-setup's own --update, the daily one at login, does not read the variable: a Windows tester changes the address by running the install line again. Tests cover a fresh install mining to the wallet with no keystore account, re-runs and updates with a new, the same or no address, malformed addresses refused with nothing installed, the unset case, and the Windows scripts' check, config template and order of steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code and security review ran on this branch: 0 finding(s) in total, none critical or high remaining.