Skip to content

Use DOMStack-owned scaffold presets and organize creator sources - #15

Closed
bcomnes wants to merge 3 commits into
masterfrom
young-pebble/shared-scaffolding
Closed

bcomnes wants to merge 3 commits into
masterfrom
young-pebble/shared-scaffolding

Conversation

@bcomnes

@bcomnes bcomnes commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Use DOMStack-owned CSS/framework scaffold presets and the shared CLI banner rather than duplicating integrations in the app creator.
  • Organize runtime sources, tests, and smoke checks under src/, test/, and scripts/, with published JavaScript and declarations under dist/.
  • Update package entry points, packaging checks, docs, and tests for the shared presets and directory layout.
  • Require @domstack/static ^12.1.0, including in generated projects, rather than accepting older releases that lack the new APIs.

Upstream dependency and release order

Depends on bcomnes/domstack#348.

@domstack/static 12.1.0 was confirmed unpublished when opening this PR. A minor release matches the additive scaffold APIs and CLI presets. Merge the upstream PR and publish 12.1.0 before merging/releasing this consumer; registry installation and registry smoke checks are expected to remain blocked until then.

Validation

  • npm test: lint passed, then type checking stopped because the currently installed @domstack/static 12.0.1 lacks lib/cli/banner.js and lib/cli/eject-features.js. Node tests did not run in this invocation.
  • The upstream scaffold/eject changes passed 107 focused tests, lint, and type checking in the companion checkout.
  • Registry smoke checks were not run because the required release intentionally does not exist yet.

@bcomnes

bcomnes commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Closing as a duplicate of #14. Compared the branch contents: #14 already contains the same creator changes and requires @domstack/static ^12.1.0, with release coordination against bcomnes/domstack#347. Continue review and release work in #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant