Skip to content

Consolidate shared website assets and authoring tools under site - #348

Merged
bcomnes merged 2 commits into
masterfrom
young-pebble/shared-scaffolding
Nov 19, 2026
Merged

bcomnes merged 2 commits into
masterfrom
young-pebble/shared-scaffolding

Conversation

@bcomnes

@bcomnes bcomnes commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Move shared fonts and licenses into site/fonts/.
  • Move author metadata and avatars into site/authors/ and site-authoring tools into site/tools/.
  • Update CSS references, avatar URLs, imports, npm scripts, font-source documentation, and tests.
  • Keep blog-specific assets colocated under blog/, including atom.svg and jsonfeed.svg, with their existing /blog/ URLs.
  • Keep router-specific pages, feed templates, and page-specific client/styles in their existing locations.
  • Preserve the authoring tools previous type-check exclusion and keep tools/raw fonts out of page discovery.

Scope and coordination

This PR is based on master and contains only the website reorganization. Scaffold APIs and CLI integration work belong to merged #347. No upstream release is required for this site-only PR.

Avatar URLs now use /site/authors/. Blog feed-icon URLs are unchanged.

Validation

  • Lint, type checking, all 31 focused site tests, and the site build passed after rebasing onto master.
  • After restoring blog asset colocation, blog tests, targeted lint, site build, and diff whitespace checks passed again.

The full Node and browser suites were not run.

@bcomnes

bcomnes commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Companion consumer PR: bcomnes/create-domstack-app#15. It requires the intentionally unpublished @domstack/static ^12.1.0; merge and release this upstream change first.

@coveralls

coveralls commented Nov 19, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 44443442163

Coverage increased (+0.1%) to 96.718%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: 4 of 4 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 12334
Covered Lines: 12062
Line Coverage: 97.79%
Relevant Branches: 4239
Covered Branches: 3967
Branch Coverage: 93.58%
Branches in Coverage %: Yes
Coverage Strength: 1051.01 hits per line

💛 - Coveralls

@bcomnes
bcomnes force-pushed the young-pebble/shared-scaffolding branch from f702cc9 to f6f8a3c Compare November 19, 2026 01:39
@bcomnes bcomnes changed the title Share scaffold integrations with the app creator and consolidate site assets Consolidate shared website assets and authoring tools under site Nov 19, 2026
@bcomnes

bcomnes commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Cleanup complete: removed the duplicate scaffold commit and rebased onto master. This PR is now site-only and can merge independently; #347 owns the scaffold APIs and release. The creator consumer is bcomnes/create-domstack-app#14; duplicate #15 is closed. This supersedes the earlier release-coordination comment.

@bcomnes
bcomnes force-pushed the young-pebble/shared-scaffolding branch from f6f8a3c to 0466ee8 Compare November 19, 2026 02:17
@bcomnes

bcomnes commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Rebased onto latest master (fb94688), including merged #347. Resolved the package.json conflict by preserving the upstream /eject-deps ignore alongside the new /site/fonts and /site/tools paths and relocated authoring commands. Validation passed: lint, type checking, all 31 focused site tests, site build, and diff whitespace checks.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the shared site asset and authoring-tool relocation.

No open issues 🎉

What changed in this PR

This site-only reorganization consolidates shared website assets and authoring tools under site/, without changing scaffolding APIs or router-specific pages.

Changes:

  • Relocate shared fonts, author metadata, avatars, and authoring tools into site/.
  • Update asset URLs, imports, npm scripts, documentation, and test expectations.
  • Preserve tool type-check exclusions and page-discovery exclusions, while keeping blog feed icons at their existing /blog/ URLs.
File Description
tsconfig.json Preserve type-check exclusion for relocated tools.
site/​tools/​blog/​shared.ts Adjust the relative path to the blog directory.
site/​tools/​blog/​publish.ts Relocate the draft-publishing tool.
site/​tools/​blog/​create.ts Update the author registry import.
site/​tools/​authors/​README.md Document relocated tools, metadata, and avatar URLs.
site/​tools/​authors/​import.ts Update author registry imports.
site/​tools/​authors/​import.test.js Update imports and expected avatar paths.
site/​lib/​blog.test.js Update author and feed avatar URL expectations.
site/​lib/​authors.ts Use the relocated registry and /site/authors/ URLs.
site/​globals/​global.css Reference the relocated shared font.
site/​fonts/​ds-weiss-gotisch/​1001fonts-ds-weiss-gotisch-eula.txt Relocate the font license alongside shared fonts.
site/​authors/​bcomnes/​avatar.jpg Relocate the author avatar.
site/​authors/​bcomnes/​author-meta.json Relocate author metadata.
package.json Update tool commands and page-discovery exclusions.
examples/​cargo-like/​src/​fonts/​SOURCES.txt Update local and upstream font-source paths.

Review effort: Balanced

@bcomnes
bcomnes merged commit 2c661eb into master Nov 19, 2026
7 checks passed
@bcomnes
bcomnes deleted the young-pebble/shared-scaffolding branch November 19, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants