Repository navigation
Consolidate shared website assets and authoring tools under site - #348
Conversation
|
Companion consumer PR: bcomnes/create-domstack-app#15. It requires the intentionally unpublished @domstack/static ^12.1.0; merge and release this upstream change first. |
Coverage Report for CI Build 44443442163Coverage increased (+0.1%) to 96.718%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
f702cc9 to
f6f8a3c
Compare
|
Cleanup complete: removed the duplicate scaffold commit and rebased onto master. This PR is now site-only and can merge independently; #347 owns the scaffold APIs and release. The creator consumer is bcomnes/create-domstack-app#14; duplicate #15 is closed. This supersedes the earlier release-coordination comment. |
f6f8a3c to
0466ee8
Compare
|
Rebased onto latest master (fb94688), including merged #347. Resolved the package.json conflict by preserving the upstream /eject-deps ignore alongside the new /site/fonts and /site/tools paths and relocated authoring commands. Validation passed: lint, type checking, all 31 focused site tests, site build, and diff whitespace checks. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the shared site asset and authoring-tool relocation.
No open issues 🎉
What changed in this PR
This site-only reorganization consolidates shared website assets and authoring tools under site/, without changing scaffolding APIs or router-specific pages.
Changes:
- Relocate shared fonts, author metadata, avatars, and authoring tools into
site/. - Update asset URLs, imports, npm scripts, documentation, and test expectations.
- Preserve tool type-check exclusions and page-discovery exclusions, while keeping blog feed icons at their existing
/blog/URLs.
| File | Description |
|---|---|
tsconfig.json |
Preserve type-check exclusion for relocated tools. |
site/tools/blog/shared.ts |
Adjust the relative path to the blog directory. |
site/tools/blog/publish.ts |
Relocate the draft-publishing tool. |
site/tools/blog/create.ts |
Update the author registry import. |
site/tools/authors/README.md |
Document relocated tools, metadata, and avatar URLs. |
site/tools/authors/import.ts |
Update author registry imports. |
site/tools/authors/import.test.js |
Update imports and expected avatar paths. |
site/lib/blog.test.js |
Update author and feed avatar URL expectations. |
site/lib/authors.ts |
Use the relocated registry and /site/authors/ URLs. |
site/globals/global.css |
Reference the relocated shared font. |
site/fonts/ds-weiss-gotisch/1001fonts-ds-weiss-gotisch-eula.txt |
Relocate the font license alongside shared fonts. |
site/authors/bcomnes/avatar.jpg |
Relocate the author avatar. |
site/authors/bcomnes/author-meta.json |
Relocate author metadata. |
package.json |
Update tool commands and page-discovery exclusions. |
examples/cargo-like/src/fonts/SOURCES.txt |
Update local and upstream font-source paths. |
Review effort: Balanced
Summary
Scope and coordination
This PR is based on master and contains only the website reorganization. Scaffold APIs and CLI integration work belong to merged #347. No upstream release is required for this site-only PR.
Avatar URLs now use /site/authors/. Blog feed-icon URLs are unchanged.
Validation
The full Node and browser suites were not run.