Skip to content

Move shared scaffolding concerns into feature-aware eject - #347

Merged
bcomnes merged 4 commits into
masterfrom
shared-scaffolding-concerns
Nov 19, 2026
Merged

bcomnes merged 4 commits into
masterfrom
shared-scaffolding-concerns

Conversation

@bcomnes

@bcomnes bcomnes commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

Move DOMStack-specific integration setup out of create-domstack-app and into DOMStack-owned eject presets, while keeping plain eject backward-compatible.

  • Add --css mine|tailwind|none and --framework none|preact|react; select Tailwind explicitly with --css tailwind, without a shorthand flag.
  • Share integration file/dependency generation with the creator and reject conflicting esbuild settings before modifying a project.
  • Maintain optional integration dependency ranges in the private eject-deps workspace so Dependabot can update them; generate lib/defaults/eject-deps.json during build:defaults and publish only that data, not an additional package manifest.
  • Generate readable, lint-clean JavaScript defaults at build/package time; eject only copies the published artifact.
  • Share the internal ASCII banner between CLI help and the creator.
  • Document the eject options and add preset, conflict, generation, and packaging coverage.

Release coordination

This is an additive minor release: publish DOMStack 12.1.0 after merging. The companion create-domstack-app branch requires @domstack/static@^12.1.0 rather than accepting older releases without these features. Merge and publish upstream before merging/releasing the creator changes.

Validation

  • Focused CLI, defaults, and dependency-helper tests passed; integration preset tests cover languages, module formats, frameworks, CSS choices, and conflicts.
  • DOMStack typecheck and lint passed.
  • Packed metadata/preset generation passed without installed workspace dependencies.
  • Four representative packed creator smoke projects passed, covering Mine/no CSS, React/Preact, Tailwind, typechecks, and GitHub Pages base paths. The full host-specific smoke matrix was not run.

@socket-security

socket-security Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​preact@​10.29.810010010098100

View full report

@bcomnes

bcomnes commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Companion consumer PR: bcomnes/create-domstack-app#14. It intentionally requires the unpublished @domstack/static@^12.1.0 range. Please merge and publish this upstream change as DOMStack 12.1.0 before merging/releasing the creator PR.

@bcomnes

bcomnes commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

PR cleanup: #348 now contains only site reorganization and no longer duplicates this scaffold work. The companion consumer is bcomnes/create-domstack-app#14 (duplicate #15 is closed). Merge/release order remains this PR, publish @domstack/static 12.1.0, then validate and merge/release the creator #14. Also pushed the one-line scaffold-test lint fix here, where it belongs; targeted ESLint passed. This supersedes my earlier comment linking the duplicate consumer.

@coveralls

coveralls commented Nov 19, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 44441241457

Coverage increased (+0.001%) to 96.662%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 14 uncovered changes across 2 files (278 of 292 lines covered, 95.21%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
scripts/build-defaults.js 47 36 76.6%
lib/cli/eject.js 100 97 97.0%
Total (11 files) 292 278 95.21%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 12334
Covered Lines: 12062
Line Coverage: 97.79%
Relevant Branches: 4202
Covered Branches: 3922
Branch Coverage: 93.34%
Branches in Coverage %: Yes
Coverage Strength: 1044.53 hits per line

💛 - Coveralls

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Tailwind watch mode leaves newly added utility classes unstyled after HTML or Markdown edits because content changes do not trigger a CSS rebuild, requiring a dependency-tracking fix and regression test.

1 open issue
What changed in this PR

This PR moves integration scaffolding into DOMStack-owned eject presets, allowing the CLI and create-domstack-app to share setup while preserving plain eject behavior.

Changes:

  • Add CSS and framework presets, dependency updates, and settings-conflict checks before project changes.
  • Maintain optional dependency ranges in a private workspace and generate publishable metadata and readable JavaScript defaults.
  • Share the CLI banner and expand documentation and regression coverage.
File Description
scripts/​build-defaults.js Generate lint-clean layouts and eject dependency metadata.
package.json Wire the private workspace and generation into build, test, and release flows.
lib/​helpers/​add-package-dependencies.test.js Test development dependency updates and metadata preservation.
lib/​helpers/​add-package-dependencies.js Support merging development dependencies.
lib/​defaults/​eject-deps.test.js Verify generated dependency ranges and metadata stripping.
lib/​defaults/​eject-deps.json Store publishable integration dependency ranges.
lib/​defaults/​default.root.layout.test.js Check generated formatting, rendering, and base paths.
lib/​defaults/​default.root.layout.js Regenerate the runtime layout as readable JavaScript.
lib/​cli/​tests/​eject.test.js Cover preset builds, conflicts, and backward compatibility.
lib/​cli/​options.js Define CSS and framework options and help text.
lib/​cli/​help.test.js Verify shared banner output and preset help.
lib/​cli/​help.js Include the shared banner in CLI help.
lib/​cli/​eject.js Extract eject execution and preflight settings-conflict checks.
lib/​cli/​eject-features.test.js Test preset combinations, validation, and dependency metadata.
lib/​cli/​eject-features.js Generate shared integration files and dependency maps.
lib/​cli/​banner.js Define the shared, unstyled ASCII banner.
lib/​cli/​args.js Validate CSS and framework selections.
index.js Export the shared banner.
eject-deps/​README.md Document dependency maintenance and publication boundaries.
eject-deps/​package.json Declare optional integration ranges in a private workspace.
docs/​cli/​README.md Document presets, conflict handling, and installation steps.
bin.js Delegate eject commands to the extracted implementation.

Review effort: Balanced

Comment thread lib/cli/eject-features.js Resolved
@bcomnes
bcomnes merged commit fb94688 into master Nov 19, 2026
7 checks passed
@bcomnes
bcomnes deleted the shared-scaffolding-concerns branch November 19, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants