Repository navigation
Move shared scaffolding concerns into feature-aware eject - #347
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Companion consumer PR: bcomnes/create-domstack-app#14. It intentionally requires the unpublished |
|
PR cleanup: #348 now contains only site reorganization and no longer duplicates this scaffold work. The companion consumer is bcomnes/create-domstack-app#14 (duplicate #15 is closed). Merge/release order remains this PR, publish @domstack/static 12.1.0, then validate and merge/release the creator #14. Also pushed the one-line scaffold-test lint fix here, where it belongs; targeted ESLint passed. This supersedes my earlier comment linking the duplicate consumer. |
Coverage Report for CI Build 44441241457Coverage increased (+0.001%) to 96.662%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
There was a problem hiding this comment.
🟡 Changes recommended
Tailwind watch mode leaves newly added utility classes unstyled after HTML or Markdown edits because content changes do not trigger a CSS rebuild, requiring a dependency-tracking fix and regression test.
1 open issue
What changed in this PR
This PR moves integration scaffolding into DOMStack-owned eject presets, allowing the CLI and create-domstack-app to share setup while preserving plain eject behavior.
Changes:
- Add CSS and framework presets, dependency updates, and settings-conflict checks before project changes.
- Maintain optional dependency ranges in a private workspace and generate publishable metadata and readable JavaScript defaults.
- Share the CLI banner and expand documentation and regression coverage.
| File | Description |
|---|---|
scripts/build-defaults.js |
Generate lint-clean layouts and eject dependency metadata. |
package.json |
Wire the private workspace and generation into build, test, and release flows. |
lib/helpers/add-package-dependencies.test.js |
Test development dependency updates and metadata preservation. |
lib/helpers/add-package-dependencies.js |
Support merging development dependencies. |
lib/defaults/eject-deps.test.js |
Verify generated dependency ranges and metadata stripping. |
lib/defaults/eject-deps.json |
Store publishable integration dependency ranges. |
lib/defaults/default.root.layout.test.js |
Check generated formatting, rendering, and base paths. |
lib/defaults/default.root.layout.js |
Regenerate the runtime layout as readable JavaScript. |
lib/cli/tests/eject.test.js |
Cover preset builds, conflicts, and backward compatibility. |
lib/cli/options.js |
Define CSS and framework options and help text. |
lib/cli/help.test.js |
Verify shared banner output and preset help. |
lib/cli/help.js |
Include the shared banner in CLI help. |
lib/cli/eject.js |
Extract eject execution and preflight settings-conflict checks. |
lib/cli/eject-features.test.js |
Test preset combinations, validation, and dependency metadata. |
lib/cli/eject-features.js |
Generate shared integration files and dependency maps. |
lib/cli/banner.js |
Define the shared, unstyled ASCII banner. |
lib/cli/args.js |
Validate CSS and framework selections. |
index.js |
Export the shared banner. |
eject-deps/README.md |
Document dependency maintenance and publication boundaries. |
eject-deps/package.json |
Declare optional integration ranges in a private workspace. |
docs/cli/README.md |
Document presets, conflict handling, and installation steps. |
bin.js |
Delegate eject commands to the extracted implementation. |
Review effort: Balanced

Summary
Move DOMStack-specific integration setup out of create-domstack-app and into DOMStack-owned eject presets, while keeping plain eject backward-compatible.
--css mine|tailwind|noneand--framework none|preact|react; select Tailwind explicitly with--css tailwind, without a shorthand flag.eject-depsworkspace so Dependabot can update them; generatelib/defaults/eject-deps.jsonduringbuild:defaultsand publish only that data, not an additional package manifest.Release coordination
This is an additive minor release: publish DOMStack 12.1.0 after merging. The companion create-domstack-app branch requires
@domstack/static@^12.1.0rather than accepting older releases without these features. Merge and publish upstream before merging/releasing the creator changes.Validation