Skip to content

Use shared DOMStack eject presets and organize creator sources - #14

Merged
bcomnes merged 5 commits into
masterfrom
shared-scaffolding-concerns
Nov 19, 2026
Merged

bcomnes merged 5 commits into
masterfrom
shared-scaffolding-concerns

Conversation

@bcomnes

@bcomnes bcomnes commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

Consume DOMStack-owned CSS/framework integration generation instead of maintaining duplicate templates and repairing ejected files.

  • Add Mine, Tailwind, and no-CSS choices through --css; remove the legacy --tailwind flag and tailwind: boolean API option.
  • Use shared integration files and dependency ranges for both installed and --no-install projects; pass the selected presets through to eject.
  • Remove stylesheet restoration and JavaScript repair/lint subprocesses, and reuse the internal DOMStack ASCII banner.
  • Organize implementation, tests, development scripts, and generated output into src/, test/, scripts/, and dist/; preserve package-level imports and the CLI command.
  • Update packaging, declaration maps, manual setup instructions, and packed smoke checks.

Migration

Replace the previous --tailwind flag with --css tailwind, and replace programmatic tailwind: true with css: 'tailwind'. The old CLI flag and boolean API option are intentionally removed.

Upstream dependency

DOMStack PR #347 is merged and DOMStack 12.1.0 is published on npm. The upstream release blocker is cleared.

The runtime dependency remains @domstack/static@^12.1.0, and generated projects use the same range. Registry installation and the shared preset/banner imports have now been verified against the published release, without local upstream resolution or tarball overrides.

Validation

  • npm test passed lint, typechecking, and all 100 source tests against published DOMStack 12.1.0.
  • npm run build and normal npm pack (including prepack build) passed in a disposable copy.
  • The unchanged full 16-project npm run smoke:registry matrix passed, covering JS/TS, Mine/Tailwind/no CSS, React/Preact, all configured deployment targets, and GitHub Pages base-path rebuilds. These validate generated configuration/builds, not live host deployment.
  • The creator, packed consumer, and all generated projects resolved DOMStack 12.1.0 from registry.npmjs.org, with published integrity matching the lockfiles. No local resolver, local upstream tarball, dependency override, or narrowed smoke matrix was used.
  • Installed package API/type checks and packaging assertions passed; declaration-map sources are included, while tests and development scripts are excluded.
  • npm emitted deprecation/install-script warnings and an audit summary of 43 vulnerabilities, including one critical; these were not investigated or changed in this compatibility validation.

@bcomnes

bcomnes commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Confirmed this PR already requires @domstack/static ^12.1.0 and has the correct release order against bcomnes/domstack#347. Its tree matches duplicate #15, which is now closed. Continue review here; bcomnes/domstack#348 is now a separate site-only reorganization and is not a release prerequisite.

@bcomnes

bcomnes commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Upstream release blocker cleared: DOMStack 12.1.0 is now published on npm. Reran both previously failing CI runs. Independently validated this PR against the published package in a disposable copy: npm test passed all 100 tests plus lint/typechecking, build/pack passed, and the unchanged full 16-project smoke:registry matrix passed. All generated apps resolved registry DOMStack 12.1.0; no local upstream overrides were used. The dependency remains ^12.1.0. PR description updated with the release status and validation results.

@bcomnes
bcomnes merged commit e14ff10 into master Nov 19, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant